-
Notifications
You must be signed in to change notification settings - Fork 7.5k
Brackets should recognize Linux as a platform #1983
Conversation
Absolutely neccessary for Live Development to function, as an extra /(forward- slash) is added when brackets.platform="win"
|
Reviewing |
|
Thanks @pritambaral. It doesn't look like you've signed our CLA. Here's the link http://dev.brackets.io/brackets-contributor-license-agreement.html and more info here https://github.com/adobe/brackets/wiki/How-to-Hack-on-Brackets. Please comment here once you you've submitted the CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add curly braces to each block. Also use 4 spaces for indentation.
|
SIgned. Do include the typo commit too. My bad. :) |
|
All done. |
src/utils/Global.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I should have been more clear. Our open curly braces go on the prior line, not on a new line. Thanks.
|
Done with 2nd pass. |
|
👍 |
|
Sorry for all this mess. I should have read the wiki and guidelines first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed this. I should have synced and ran JSLint. else if should be on the same line as the close brace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. :)
|
Sorry to miss those other JSLint errors. I should have seen those last time. |
Brackets should recognize Linux as a platform
|
Merged. |
Absolutely neccessary for Live Development to function, as an extra /(forward-
slash) is added when brackets.platform="win"