This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Adding hover preview unit tests #3475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Contributor
There was a problem hiding this comment.
Anything exported for unit test only should be prefixes with underscore (_).
Contributor
|
Done with initial review. |
Contributor
|
For the task "Update smoke test with Hover Preview (popover UI and preview content)" I wrote a unit test to automate this instead, and I pushed it to this branch. |
Conflicts: src/extensions/default/HoverPreview/main.js
Update test file with some repeating-linear-gradients, repeating-radial-gradients, and some invalid color names. Update unit tests with the correct cursor positions for all unit tests.
Contributor
Author
|
@redmunds I reviewed your unit tests and updated the cursor positions when I made changes to the test file. Ready for re-review. |
Contributor
|
Merging. |
redmunds
added a commit
that referenced
this pull request
Apr 22, 2013
Adding hover preview unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.