Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

[REVIEW ONLY] Bare async provider implementation. #6375

Closed
busykai wants to merge 1 commit into from
Closed

[REVIEW ONLY] Bare async provider implementation. #6375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 39 additions & 20 deletions src/language/CodeInspection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,29 +170,48 @@ define(function (require, exports, module) {
response.resolve(null);
return response.promise();
}

DocumentManager.getDocumentText(file)
.done(function (fileText) {
var perfTimerInspector = PerfUtils.markStart("CodeInspection:\t" + file.fullPath);

providerList.forEach(function (provider) {
var perfTimerProvider = PerfUtils.markStart("CodeInspection '" + provider.name + "':\t" + file.fullPath);

try {
var scanResult = provider.scanFile(fileText, file.fullPath);
results.push({provider: provider, result: scanResult});
} catch (err) {
console.error("[CodeInspection] Provider " + provider.name + " threw an error: " + err);
response.reject(err);
return;
var perfTimerInspector = PerfUtils.markStart("CodeInspection:\t" + file.fullPath),
masterPromise;

masterPromise = Async.doInParallel(providerList, function (provider) {
var perfTimerProvider = PerfUtils.markStart("CodeInspection '" + provider.name + "':\t" + file.fullPath),
runPromise = new $.Deferred();

if (provider.scanFileAsync) {
provider.scanFileAsync(fileText, file.fullPath)
.then(function (scanResult) {
results.push({provider: provider, result: scanResult});
PerfUtils.addMeasurement(perfTimerProvider);
runPromise.resolve();
})
.fail(function (err) {
console.error("[CodeInpsection] Provider " + provider.name + " (async) failed: " + err);
runPromise.reject(err);
});
} else {
try {
var scanResult = provider.scanFile(fileText, file.fullPath);
results.push({provider: provider, result: scanResult});
PerfUtils.addMeasurement(perfTimerProvider);
runPromise.resolve();
} catch (err) {
console.error("[CodeInspection] Provider " + provider.name + " (sync) threw an error: " + err);
runPromise.reject(err);
return;
}
}
return runPromise.promise();

PerfUtils.addMeasurement(perfTimerProvider);
}, false);

masterPromise.then(function () {
PerfUtils.addMeasurement(perfTimerInspector);
response.resolve(results);
});

PerfUtils.addMeasurement(perfTimerInspector);

response.resolve(results);
})
.fail(function (err) {
console.error("[CodeInspection] Could not read file for inspection: " + file.fullPath);
Expand Down Expand Up @@ -328,7 +347,7 @@ define(function (require, exports, module) {

html = Mustache.render(ResultsTemplate, {reportList: allErrors});
});

// Update results table
var perfTimerDOM = PerfUtils.markStart("ProblemsPanel render:\t" + currentDoc.file.fullPath);

Expand Down Expand Up @@ -377,15 +396,15 @@ define(function (require, exports, module) {
if (!_providers[languageId]) {
_providers[languageId] = [];
}

if (languageId === "javascript") {
// This is a special case to enable extension provider to replace the JSLint provider
// in favor of their own implementation
_.remove(_providers[languageId], function (registeredProvider) {
return registeredProvider.name === "JSLint";
});
}

_providers[languageId].push(provider);

run();
Expand Down