Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@redmunds
Copy link
Contributor

I learned this when working with the contribution of the Croatian language.

Technically, any non-code contribution can be made this way, so maybe there's a better place for this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not clear when I first read this sentence until I actually click on the [+] button. So it may be clearer to mention that clicking on the [+] button will bring you to a new page with a text field for your new filename. You can create subfolder in the same text field.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should describe how to get the English copy to the editing page so that translators know where to get the source code.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@randyredmunds
Copy link

@RaymondLim Ready for another review. I took your advice and walked through all cases, so I added a lot more detail.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding the following as step 4.

Add this comment /* Last translated for SHA_of_root_strings.js */ at the end of your strings.js and replace SHA_of_root_strings.js with the actual SHA. You can copy the actual SHA in this [history page](https://github.com/adobe/brackets/commits/master/src/nls/root/strings.js) by hovering on the one you used for this translation and click on Copy SHA button.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, but I added as Step 3 since this is where file is edited.

@RaymondLim
Copy link
Contributor

Looks good, but I would like to enforce web interface users to record SHA as well.

@redmunds
Copy link
Contributor Author

Ready for another review.

RaymondLim added a commit that referenced this pull request May 21, 2014
Contributing translations directly from github
@RaymondLim RaymondLim merged commit 1ec193d into master May 21, 2014
@RaymondLim RaymondLim deleted the randy/translations-from-github branch May 21, 2014 21:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants