Themes in Core v1 #8302

MiguelCastillo · 2014-07-03T14:31:42Z

Fresh branch from a clean master

This works by checking if the “theme” field exists in the package.json to determine if the extension ought to be treated as a theme or not.

So that we can preemptively figure out if the extension is a theme or a regular extension.

…rresponding folders.

…SETTINGS

… theme name

…vents

…js to FileLoader.js

…ttings dialog

…enable multi select

MiguelCastillo · 2014-07-14T14:18:40Z

@dangoor Awesome! I will go through those follow up items and work my way through them.

MiguelCastillo · 2014-07-14T14:22:59Z

@dangoor We should add in the list the migration to the fonts api

ryanstewart · 2014-07-14T16:09:59Z

This is awesome! Can't wait to see this in the release. Major props @MiguelCastillo! 💥

dangoor · 2014-07-14T16:15:43Z

@MiguelCastillo We could either add a new issue for that or just modify the existing pull request (#8305)

larz0 · 2014-07-14T16:51:05Z

I'll test this today. Great timing!

TomMalbran · 2014-07-15T02:38:21Z

src/extensibility/ExtensionManager.js

Missing id paramenter

TomMalbran · 2014-07-15T02:40:55Z

@MiguelCastillo I went through all the JSDocs and gave you some feedback.

MiguelCastillo · 2014-07-15T03:25:56Z

@TomMalbran Thanks for your feedback! Definitely helpful. I wasn't sure how to do the one for array of themes. :)

MiguelCastillo · 2014-07-15T18:51:51Z

@TomMalbran I will make these adjustments part of the PR for the font api if that's ok

TomMalbran · 2014-07-15T18:54:48Z

Sure. But might be nice to have good JSDocs before the next version so that the API Docs are accurate.

MiguelCastillo · 2014-07-15T18:55:48Z

You don't think we will be landing this one soon?

MiguelCastillo · 2014-07-15T18:56:16Z

Sorry, not this one... Font api PR

TomMalbran · 2014-07-15T19:01:07Z

I don't know. I hope it does.

MiguelCastillo · 2014-07-15T19:03:02Z

Hmmm, that could a problem... There is cleanup in Themes that's pending on the font API. And this issue #8381

peterflynn · 2014-07-16T00:13:28Z

Yeah, it's probably safe to assume it'll have to land in this sprint since it's fixing issues that we don't want to ship with...

MiguelCastillo · 2014-07-16T00:20:22Z

@peterflynn Awesome!

MiguelCastillo added 30 commits April 23, 2014 21:04

Initial commit to integrate themes into brackets core

d12d87b

Delete stale Init.js file

657df85

Cleaned up jslint errors/warnings

5cb4085

Removed string.js. Not needed anymore

abf3e49

Removed custom themes from the themes extension

5473380

Cleaned up extra white spaces

a1dea7e

Adjusted comments to follow convention

6f1df7a

Adding CMD_THEMES to nls strings.js

361d715

Checking support to load themes as extensions

7a8997f

This works by checking if the “theme” field exists in the package.json to determine if the extension ought to be treated as a theme or not.

Refactored ExtensionLoader so that it can preload package.json

2856006

So that we can preemptively figure out if the extension is a theme or a regular extension.

Removed logic to load CodeMirror themes automatically

b0df2fc

themes settings css and html files to their styles and htmlContent co…

1c64c1a

…rresponding folders.

Renames settings.js to settingsmanager.js

a572d22

Moved views/settings to ThemeSettingsDialog

e68c3ec

Removed paths from settings. That's ole stuff from themes extension

43b5abb

Changed (void 0) checks to undefined.

92ac359

Merge remote-tracking branch 'upstream/master'

fb54d2f

Removed obsolete files

bc7054f

Change exports.THEMES to exports.CMD_THEMES_SETTINGS_OPEN

767c9e5

Renamed view export from CMD_THEMES_SETTINGS_OPEN to CMD_THEMES_OPEN_…

5c6f83b

…SETTINGS

Removing license file as its no longer needed due to CLA

d83bf29

Enabling the use of the package title to be the primary source of the…

0854441

… theme name

Big refactor to make use of definePreference and rely on its change e…

f9d29db

…vents

Reading text files with FileUtils.readAsText

d55254f

Change to use FileUtils.getFileExtension

f686926

Exposing theme change event and loadDirectory interface

02515b1

Moved CodeMirrorAddons from themes to a global module that brackets uses

e037fc0

Removed loadList to clean up the code a bit. Also renamed ThemeFiles.…

8ee527b

…js to FileLoader.js

Fixed issue with selected theme not properly getting select in the se…

fe05d09

…ttings dialog

Setting themes up so that it can support mixing themes if we were to …

f8eac83

…enable multi select

TomMalbran reviewed Jul 15, 2014
View reviewed changes

src/extensibility/ExtensionManager.js

Copy link

Contributor

TomMalbran Jul 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing id paramenter

core-ai-bot mentioned this pull request Aug 30, 2021

[CLOSED] Themes in Core v1 brackets-archive/bracketsIssues#7421

Open

Themes in Core v1 #8302

Themes in Core v1 #8302

Uh oh!

Conversation

MiguelCastillo commented Jul 3, 2014

Uh oh!

MiguelCastillo commented Jul 14, 2014

Uh oh!

MiguelCastillo commented Jul 14, 2014

Uh oh!

ryanstewart commented Jul 14, 2014

Uh oh!

dangoor commented Jul 14, 2014

Uh oh!

larz0 commented Jul 14, 2014

Uh oh!

TomMalbran Jul 15, 2014

Choose a reason for hiding this comment

Uh oh!

TomMalbran commented Jul 15, 2014

Uh oh!

MiguelCastillo commented Jul 15, 2014

Uh oh!

MiguelCastillo commented Jul 15, 2014

Uh oh!

TomMalbran commented Jul 15, 2014

Uh oh!

MiguelCastillo commented Jul 15, 2014

Uh oh!

MiguelCastillo commented Jul 15, 2014

Uh oh!

TomMalbran commented Jul 15, 2014

Uh oh!

MiguelCastillo commented Jul 15, 2014

Uh oh!

peterflynn commented Jul 16, 2014

Uh oh!

MiguelCastillo commented Jul 16, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants