Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

myaghobi/persian translation #8421

Merged
redmunds merged 25 commits into from
Jul 19, 2014
Merged

myaghobi/persian translation #8421

redmunds merged 25 commits into from
Jul 19, 2014

Conversation

@myaaghubi
Copy link
Contributor

@myaaghubi myaaghubi commented Jul 16, 2014

update persian translation

Marcel Gerber and others added 22 commits November 5, 2013 21:20
@myaaghubi
Prohibit error message when starting live dev from an image file
1007b66
@larz0 @myaaghubi
This is for adobe#5726. Fix based on @SAplayer's feedback.
f2d43ba
@larz0 @myaaghubi
Removing whitespace between contributor images to remove inline-block…
cba92d7 
…'s default spacing.
@larz0 @myaaghubi
Tweaked img-scale indicator.
19c2fe3
@ingorichter @myaaghubi
-removed the conflicting language definition for dust.js files and added
f37138c 
the dust extension to the ejs language definition.
@redmunds @myaaghubi
fix cshtml conflict
032ee69
@larz0 @myaaghubi
Using multiplication sign instead of x in image dimensions.
d93c22b
@larz0 @myaaghubi
Using multiplication sign instead x for image quick view.
3d8e8e1
@larz0 @myaaghubi
Using entities based on Raymond's feedback.
7f0db89
@larz0 @myaaghubi
Using html() based on Raymond's feedback.
ebbb512
@walfgithub @myaaghubi
Updated by ALF automation.
f0e1ea1
@lkcampbell @myaaghubi
Show decoded urls in hint list and insert encoded urls into editor
48b3a1a
@walfgithub @myaaghubi
Updated by ALF automation.
5fea918
@myaaghubi
update fa-ir\string.js
521615f
@myaaghubi
Merge remote-tracking branch 'upstream/master'
d72f887
@myaaghubi
Merge remote-tracking branch 'upstream/master'
cf2cd1c
@myaaghubi
Merge remote-tracking branch 'upstream/master'
6694001
@myaaghubi
Merge remote-tracking branch 'upstream/master'
9e607c7
@myaaghubi
update Persian translation
5eaa02e
@myaaghubi
Persion translation for Sprint 38
07c35cc
@myaaghubi
Persian translation for sprint 41
c8fe5e4 
Sorry for the delay
@myaaghubi
update persian translation
c932ddb
@myaaghubi
Copy link
Contributor Author

myaaghubi commented Jul 17, 2014

@redmunds, what's the problem again?

@redmunds
Copy link
Contributor

redmunds commented Jul 17, 2014

There were some comments that were unnecesarily updated, but besides that, it looks ready for review. Triage Complete.

Do you know anyone that can review the string changes?

@redmunds
Copy link
Contributor

redmunds commented Jul 17, 2014

I just noticed that the indentation differences are causing errors that need to be fixed. See Travis CI Details link..

Also, there are commits showing up in list that shouldn't be there (although I don't see any changes in diff).

peterflynn
peterflynn reviewed Jul 17, 2014
View reviewed changes
src/nls/fa-ir/strings.js Outdated
Copy link
Member

@peterflynn peterflynn Jul 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just a display error in GitHub due to RTL or something? It looks like a syntax error since the previous line ends in ",...

Copy link
Contributor Author

@myaaghubi myaaghubi Jul 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterflynn thank for review. The main problem was on line 71.

@myaaghubi
Copy link
Contributor Author

myaaghubi commented Jul 19, 2014

Thank you both, After much effort, the problem was solved, but the Travis CI is very sensitive

@myaaghubi myaaghubi closed this Jul 19, 2014
@myaaghubi myaaghubi reopened this Jul 19, 2014
@redmunds
Copy link
Contributor

redmunds commented Jul 19, 2014

Thanks. Merging.

redmunds added a commit that referenced this pull request Jul 19, 2014
@redmunds
Merge pull request #8421 from mohammadyaghobi/my/persian-translation
057e73c 
myaghobi/persian translation
@redmunds redmunds merged commit 057e73c into adobe:master Jul 19, 2014
@core-ai-bot core-ai-bot mentioned this pull request Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

PR Triage Complete

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@myaaghubi @redmunds @peterflynn @larz0 @ingorichter @walfgithub @lkcampbell