RAC: Multi select with Shift is not working in Virtualized GridList

[piecyk]

Provide a general summary of the issue here

When testing GridList with virtualization library like @tanstack/react-virtual kinda looks like it works 🎉

One issue noticed, when using selectionBehavior replace and selecting multi rows with Shift. If we select item from current render items then it works, issue is when selecting one and scroll down a bit to new rendered items, then it breaks, item is focused but no selection.

Nagranie.z.ekranu.2023-09-13.o.08.10.57.mov

Also when scrolling focus is changing, is there some autofocus enabled?

🤔 Expected Behavior?

Items should be selected.

😯 Current Behavior

Items are not selected and row is focused.

💁 Possible Solution

No response

🔦 Context

No response

🖥️ Steps to Reproduce

https://codesandbox.io/s/friendly-tamas-3zpl6q?file=/src/App.js

Version

1.0.0-beta.0

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

MacOS

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

[devongovett]

Virtualization is not possible with the current component implementation. GridList must know about all of the items in order to implement selection, but you are only passing a subset of the items in. That's why shift select doesn't work: by the time you scroll down, you've removed many of the previously visible items from the GridList entirely so it cannot determine what the ids of the items in-between were.

For virtualization to work correctly, it would need to be implemented inside the GridList rather than outside. You could do this by dropping down to the useGridList hook API instead of using the component. Eventually we may add support for virtualization to the components too but it's not on our short term roadmap.

[piecyk]

Thanks @devongovett that make sense.

What if don't need selectionMode and disable it, from quick testing it kinda works 🤔

Eventually we may add support for virtualization to the components too but it's not on our short term roadmap.

Ok, also will try to look into that 👍

[devongovett]

Without selection some features would still be broken. For example, if you use the Home and End keys to navigate to the first/last row, it would only take you to the currently visible rows not the complete set of items.