react-transition-group: pass nodeRef so findDOMNode isn't used#1241
Closed
snowystinger wants to merge 11 commits into
Closed
react-transition-group: pass nodeRef so findDOMNode isn't used#1241snowystinger wants to merge 11 commits into
snowystinger wants to merge 11 commits into
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
dannify
reviewed
Nov 17, 2020
| let tooltipRef = useRef(); | ||
| let [trigger, tooltip] = React.Children.toArray(children); | ||
|
|
||
| // @ts-ignore |
Member
There was a problem hiding this comment.
there is a lot of ignoring here. What are we ignoring?
|
Build successful! 🎉 |
devongovett
reviewed
Dec 23, 2020
|
|
||
| // this does mean that we can't have some element wrapping the Tooltip | ||
| // we'd need to do it through context if we wanted to allow for that | ||
| let tooltipWithRef = React.cloneElement(tooltip, { |
Member
There was a problem hiding this comment.
Yeah we should avoid cloneElement. Someone might do something like <MyFancyTooltip> that wraps <Tooltip> and not pass through the ref...
|
Build successful! 🎉 |
Member
|
I think this isn't needed anymore? |
Member
Author
|
I don't remember most of the context at this point, but do we not want to upgrade react-transition-group? Still, happy to close, we can open an issue to do the upgrade at another point |
|
Hey, what's preventing us from getting this merged ? |
Member
|
Related: #3291 |
Member
|
Handled in #3865 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1108 is failing due to Adobe CLA, opening a new PR to fix that
@mischnic :
Part of #779
There are more problems with strict mode (which is why I didn't enable strict mode in tests or Storybook yet), this is just fixing the react-transition-group and findDOMNode problem.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: