Skip to content

SearchAutocomplete#2243

Closed
reidbarber wants to merge 64 commits into
mainfrom
Issue-2084-SearchAutoComplete
Closed

SearchAutocomplete#2243
reidbarber wants to merge 64 commits into
mainfrom
Issue-2084-SearchAutoComplete

Conversation

@reidbarber
Copy link
Copy Markdown
Member

@reidbarber reidbarber commented Aug 23, 2021 •
edited
Loading

Closes #2084

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Check SearchWithin sections of Docs and Storybook, along with tests and chromatic stories.

🧢 Your Project:

@adobe-bot
Copy link
Copy Markdown

adobe-bot commented Aug 23, 2021

Build successful! 🎉

@adobe-bot
Copy link
Copy Markdown

adobe-bot commented Aug 27, 2021

Build successful! 🎉

@adobe-bot
Copy link
Copy Markdown

adobe-bot commented Aug 31, 2021

Build successful! 🎉

@adobe-bot
Copy link
Copy Markdown

adobe-bot commented Sep 15, 2021

Build successful! 🎉

LFDanLu
LFDanLu reviewed Sep 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of things I noticed after the new commits

Comment thread packages/@react-aria/searchfield/docs/useSearchAutocomplete.mdx
Comment thread packages/@react-aria/searchfield/docs/useSearchAutocomplete.mdx
@adobe-bot
Copy link
Copy Markdown

adobe-bot commented Sep 16, 2021

Build successful! 🎉

@adobe-bot
Copy link
Copy Markdown

adobe-bot commented Sep 17, 2021

Build successful! 🎉

@adobe-bot
Copy link
Copy Markdown

adobe-bot commented Sep 20, 2021

Build successful! 🎉

@adobe-bot
Copy link
Copy Markdown

adobe-bot commented Sep 20, 2021

Build successful! 🎉

@devongovett
Copy link
Copy Markdown
Member

devongovett commented Sep 20, 2021

Danni and I were discussing, and we think it would be good to move this into its own package for now (@react-aria/autocomplete, and @react-spectrum/autocomplete). We aren't sure exactly when we'll have time to finish this off, and would like to avoid putting the search field packages back into alpha (which will show up in the docs) for the time being. It may end up moving again, but for now I think a separate package would be better. Sorry to change course! Hopefully not too much work to move it. 😄

@reidbarber
Copy link
Copy Markdown
Member Author

reidbarber commented Sep 20, 2021

@devongovett Sounds good! That definitely makes the most sense looking forward.

snowystinger
snowystinger reviewed Sep 21, 2021
View reviewed changes
Comment thread packages/@react-types/searchfield/package.json
@devongovett
Copy link
Copy Markdown
Member

devongovett commented Sep 22, 2021

Superseded by #2371.

@devongovett devongovett deleted the Issue-2084-SearchAutoComplete branch September 22, 2021 21:51
@reidbarber reidbarber mentioned this pull request Sep 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snowystinger snowystinger snowystinger left review comments

@LFDanLu LFDanLu LFDanLu left review comments

@dannify dannify Awaiting requested review from dannify

@devongovett devongovett Awaiting requested review from devongovett

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SearchAutocomplete

5 participants

@reidbarber @adobe-bot @LFDanLu @devongovett @snowystinger