Rough Cardview scale support#2297
Merged
Merged
Conversation
LFDanLu
requested review from
dannify,
devongovett and
snowystinger
as code owners
…nto cardview_scale_support
if user only provides the layout constructor to CardView, we have to set itemPadding values for M/L scale for them after initializing the layout
|
Build successful! 🎉 |
LFDanLu
commented
Sep 14, 2021
Comment on lines
+47
to
+53
| if (typeof layout === 'function') { | ||
| if (layoutType === 'grid') { | ||
| cardViewLayout.itemPadding = scale === 'large' ? 116 : 95; | ||
| } else if (layoutType === 'gallery') { | ||
| cardViewLayout.itemPadding = scale === 'large' ? 143 : 114; | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
If user passes a layout constructor to the CardView we have set the itemPadding for the user depending on the scale since the layout doesn't have a concept of scale. Perhaps the layout should have a scale option?
…nto cardview_scale_support
|
Build successful! 🎉 |
…nto cardview_scale_support
|
Build successful! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: