Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions packages/@react-aria/utils/src/useResizeObserver.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {RefObject, useEffect} from 'react';
import {RefObject, useEffect, useRef} from 'react';

function hasResizeObserver() {
return typeof window.ResizeObserver !== 'undefined';
Expand All @@ -11,6 +11,7 @@ type useResizeObserverOptionsType<T> = {

export function useResizeObserver<T extends Element>(options: useResizeObserverOptionsType<T>) {
const {ref, onResize} = options;
let raf = useRef(null);

useEffect(() => {
let element = ref?.current;
Expand All @@ -24,17 +25,28 @@ export function useResizeObserver<T extends Element>(options: useResizeObserverO
window.removeEventListener('resize', onResize, false);
};
} else {

const resizeObserverInstance = new window.ResizeObserver((entries) => {
if (!entries.length) {
if (raf.current) {
return;
}

onResize();
// avoid Error - ResizeObserver loop limit exceeded
// it's ok to use a raf, ResizeObservers are already async and now we're just debouncing on frames
raf.current = window.requestAnimationFrame(() => {
raf.current = null;
if (!Array.isArray(entries) || !entries.length) {
return;
}
onResize();
});
Comment thread
snowystinger marked this conversation as resolved.
});

resizeObserverInstance.observe(element);

return () => {
if (raf.current) {
window.cancelAnimationFrame(raf.current);
raf.current = null;
}
if (element) {
resizeObserverInstance.unobserve(element);
}
Expand Down
55 changes: 55 additions & 0 deletions packages/@react-aria/utils/stories/useResizeObserver.stories.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@

import {Button} from '@react-spectrum/button';
import {Meta, Story} from '@storybook/react';
import React, {useEffect, useRef, useState} from 'react';
import {useResizeObserver} from '../src';

export default {
title: 'useResizeObserver'
} as Meta;

const Template: Story<any> = () => (
<App />
);

export const UseResizeObserverLoopLimit = Template.bind({});
UseResizeObserverLoopLimit.args = {};

const animalSet = ['🐰', '🦊', '🐻', '🐭', '🐼', '🐸'];
function App() {
let ref = useRef<HTMLDivElement>();
let index = useRef(0);
let [animals, setAnimals] = useState([animalSet[0]]);

function insertAnimal() {
index.current = index.current + 1;
setAnimals(prev => [...prev, animalSet[index.current % animalSet.length]]);
}

useEffect(() => {
let onError = (err) => {
console.log(err);
};
window.addEventListener('error', onError);
return () => {
window.removeEventListener('error', onError);
};
}, []);

let onResize = () => {
const {width} = ref.current.getBoundingClientRect();

ref.current.style.height = `${width}px`;
};

useResizeObserver({onResize, ref});

return (
<>
<div ref={ref} id="red-box">
{animals}
</div>
<Button variant="primary" onPress={insertAnimal}>Insert Next Animal</Button>
</>
);
}