(WIP) Refactor listview to always focus the row#2993
Closed
LFDanLu wants to merge 9 commits into
Closed
Conversation
Felt that the previous modifications to GridKeyboardDelegate were too specific to ListView so split out the changes. Also fixes pageUp/Down/Home/End when you are focused on the ListView row (we forgot to pass the layout to the delegate previously)
needed to override getItemRect for the ListView keyboard delegate so that it always uses the row key, namely due to the gridcell keys being unavailable in the listlayout. Changed getItem and getItemRect to protected funcs in GridKeyboardDelegate so I could do that
LFDanLu
force-pushed
the
refactor_listview_row_focus
branch
from
fbb6f39 to
2a92a70
Compare
Member
Author
|
Noticed some strange behavior when navigating the listview via ctrl +option + arrow keys with voiceover on, seems to snap you back to the "old" focused row when you move the voiceover cursor on a focusable element. Seems to be pre-existing in TableView and ListView, maybe something to do with focus not truly changing when moving the voiceover cursor... |
5 tasks
Member
Author
|
favoring #3000 over this one, closing for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2946
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: