Stop propagation when pressing Enter on a native link#3380
Merged
Conversation
|
Build successful! 🎉 |
majornista
approved these changes
Aug 4, 2022
Collaborator
|
Thanks for this. LGTM |
dannify
approved these changes
Aug 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2599. Closes #2619.
Slightly different version of the fix in #2619 (test and partial fix reused). This fixes scrolling and selection when pressing Space when focused on a link in a TableView, while letting Enter trigger the link natively. Two fixes:
currentTargetrather thantargetto check whether to handle a keyboard event. This ensures the check for link handling doesn't apply when the table row is handling an event that propagated up from a link (e.g. Space key). This is the same as in fix(#2599): TableView: space key on link within cell scrolls the TableView down a page #2619.📝 Test Instructions: