fix(#1999): refactor to use SearchAutocomplete and v3 of AlgoliaSearch API#3383
Merged
Conversation
solimant
previously approved these changes
Aug 4, 2022
reidbarber
reviewed
Aug 4, 2022
Member
reidbarber
left a comment
There was a problem hiding this comment.
Just a couple initial comments. This is going to be great to have.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
devongovett
reviewed
Aug 30, 2022
devongovett
reviewed
Aug 30, 2022
This comment was marked as outdated.
This comment was marked as outdated.
LFDanLu
previously approved these changes
Apr 6, 2023
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
devongovett
reviewed
Apr 11, 2023
|
Build successful! 🎉 |
LFDanLu
approved these changes
Apr 12, 2023
snowystinger
approved these changes
Apr 12, 2023
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
devongovett
approved these changes
Apr 12, 2023
Collaborator
cgood92
pushed a commit
to cgood92/react-spectrum
that referenced
this pull request
May 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes #1999 replacing #2016
From 3/20/23 Testing session:
Algolia configuration fixes for later:
✅ Pull Request Checklist:
📝 Test Instructions:
Test documentation search functionality using https://reactspectrum.blob.core.windows.net/reactspectrum/d5aed9e2838b40d54ba7e7ba7a7a77f8fec212c6/docs/index.html.
🧢 Your Project:
RSP