Skip to content

fix(#1999): refactor to use SearchAutocomplete and v3 of AlgoliaSearch API#3383

Merged
devongovett merged 85 commits into
mainfrom
1999
Apr 12, 2023
Merged

fix(#1999): refactor to use SearchAutocomplete and v3 of AlgoliaSearch API#3383
devongovett merged 85 commits into
mainfrom
1999

Conversation

@majornista
Copy link
Copy Markdown
Collaborator

@majornista majornista commented Aug 4, 2022

Closes #1999 replacing #2016

From 3/20/23 Testing session:

  • Adds Algolia logo to the ListBox examples on the docs page for ListBox. Appears to be that it adds to the first ListBox on the page. When it does this, it closes the popover and continues to close it on every keystroke. (RS)
  • Cannot access the Algolia link via keyboard. Cannot access the Algolia link via VO with keyboard. (RS)
  • VO reads "T ableView" if you search "T" and go to the first result, because of the highlighted letter (DG)
  • VO hierarchy not present, so if two pages have the same title, both are read the same way with no indication that they are two separate pages. Might be able to read off the Item description as well. (RS) type in 'example' and navigate the results.
    • Note: Don't have access to descriptions. VO reads both words off (i.e. "Example" then "Radio Group") so should be ok.

Algolia configuration fixes for later:

  • I don't like that a search for "useDialog" shows the hook after a bunch of other pages. Shouldn't the page that matches the search result show before a page that the term is in? (KT)
  • Search logic should be updated to support fuzzy logic. "useComboBox" should be a result if you search "combobox" (RB)
  • There are a bunch of search results edge cases that get weirdness, for example "Content" picks up the section header as well as the component. Devon suggested the keywords aren't being factored in. (KT)

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue 1999.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test documentation search functionality using https://reactspectrum.blob.core.windows.net/reactspectrum/d5aed9e2838b40d54ba7e7ba7a7a77f8fec212c6/docs/index.html.

🧢 Your Project:

RSP

solimant
solimant previously approved these changes Aug 4, 2022
Copy link
Copy Markdown
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple initial comments. This is going to be great to have.

Comment thread packages/dev/docs/src/client.js Outdated
Comment thread packages/dev/docs/src/client.js Outdated
@adobe-bot

This comment was marked as outdated.

@adobe-bot

This comment was marked as outdated.

@adobe-bot

This comment was marked as outdated.

@adobe-bot

This comment was marked as outdated.

@adobe-bot

This comment was marked as outdated.

@adobe-bot

This comment was marked as outdated.

@adobe-bot

This comment was marked as outdated.

Comment thread packages/dev/docs/src/client.js Outdated
Comment thread packages/dev/docs/src/client.js Outdated
@adobe-bot

This comment was marked as outdated.

@adobe-bot

This comment was marked as outdated.

@adobe-bot

This comment was marked as outdated.

Comment thread packages/dev/docs/src/client.js Outdated
Comment thread packages/dev/docs/src/client.js Outdated
@adobe-bot

This comment was marked as outdated.

LFDanLu
LFDanLu previously approved these changes Apr 6, 2023
@rspbot
Copy link
Copy Markdown

rspbot commented Apr 10, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 11, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 11, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 11, 2023

This reverts commit 9ef1739.
This reverts commit 033bfbf.
@rspbot
Copy link
Copy Markdown

rspbot commented Apr 11, 2023

Comment thread packages/dev/docs/src/attachToToC.js Outdated
@rspbot
Copy link
Copy Markdown

rspbot commented Apr 12, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 12, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 12, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@devongovett devongovett merged commit b5a193a into main Apr 12, 2023
@devongovett devongovett mentioned this pull request Apr 12, 2023
5 tasks
@solimant
Copy link
Copy Markdown
Collaborator

solimant commented Apr 12, 2023

EDIT: shows on the build instance, not on react-spectrum.adobe.com -- can ignore

Just a heads-up -- this is what it looks like on mobile:
image

When you type:
image

cgood92 pushed a commit to cgood92/react-spectrum that referenced this pull request May 9, 2023
@reidbarber reidbarber deleted the 1999 branch January 16, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Would like to be able to search the docs

8 participants