Skip to content

live-announcer incorrectly copies visually hidden styles#3792

Closed
mitchellwarr wants to merge 1 commit into
adobe:mainfrom
mitchellwarr:patch-1
Closed

live-announcer incorrectly copies visually hidden styles#3792
mitchellwarr wants to merge 1 commit into
adobe:mainfrom
mitchellwarr:patch-1

Conversation

@mitchellwarr
Copy link
Copy Markdown

Closes #3791

Object.assign node.style does not accept 1 as a value for width and height; it requires '1px'

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

This code sandbox shows what bug this PR fixes: https://codesandbox.io/s/eager-jackson-gy3btv?file=/package.json

Issue here: adobe#3791

Object.assign node.style does not accept 1 as a value for width and height; it requires '1px'
@snowystinger
Copy link
Copy Markdown
Member

Great find, thanks for pointing it out and contributing. If you'll follow the instructions here https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement, then close and reopen this PR, we should be able to get it reviewed in short order.

@snowystinger snowystinger added the small review Easy to review PR label Nov 28, 2022
@snowystinger
Copy link
Copy Markdown
Member

Linking another bug that this might address. Shouldn't hold up the review, it'll likely be easier to test it after using the codesandbox on it. I just don't want to forget to check. #3603

@mitchellwarr
Copy link
Copy Markdown
Author

My companies legal process in signing that CLA might take a while. If anyone wants to fix this bug themselves, it might be faster to do so

@snowystinger
Copy link
Copy Markdown
Member

thanks for the update, i'll push it in a minute

@snowystinger
Copy link
Copy Markdown
Member

closing in favor of #3807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small review Easy to review PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

live-announcer incorrectly copies visually hidden styles

2 participants