live-announcer incorrectly copies visually hidden styles#3792
Closed
mitchellwarr wants to merge 1 commit into
Closed
live-announcer incorrectly copies visually hidden styles#3792mitchellwarr wants to merge 1 commit into
mitchellwarr wants to merge 1 commit into
Conversation
Issue here: adobe#3791 Object.assign node.style does not accept 1 as a value for width and height; it requires '1px'
Member
|
Great find, thanks for pointing it out and contributing. If you'll follow the instructions here https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement, then close and reopen this PR, we should be able to get it reviewed in short order. |
Member
|
Linking another bug that this might address. Shouldn't hold up the review, it'll likely be easier to test it after using the codesandbox on it. I just don't want to forget to check. #3603 |
Author
|
My companies legal process in signing that CLA might take a while. If anyone wants to fix this bug themselves, it might be faster to do so |
Member
|
thanks for the update, i'll push it in a minute |
5 tasks
Member
|
closing in favor of #3807 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3791
Object.assignnode.styledoes not accept1as a value for width and height; it requires'1px'✅ Pull Request Checklist:
📝 Test Instructions:
This code sandbox shows what bug this PR fixes: https://codesandbox.io/s/eager-jackson-gy3btv?file=/package.json