Partial Storybook CSF 3 story conversions#3824
Conversation
…nto csf_3_conversions
reidbarber
left a comment
There was a problem hiding this comment.
There are a few things I noticed we can improve, but they can definitely be handled in a follow-up:
For argTypes that we don't want to appear in the Controls panel (i.e. children, onOpenChange), we can add control: false.
| onChange: action('onChange'), | ||
| onChangeEnd: action('onChangeEnd') | ||
| }, | ||
| argTypes: { |
There was a problem hiding this comment.
Currently updating the channel control (a text field) gives an error, so we might need this:
channel: {
control: {
type: 'select',
options: ['red', 'green', 'blue', 'hue', 'saturation', 'lightness', 'alpha']
}
}You could also add this to any of the other color stories for xChannel, yChannel, etc.
There was a problem hiding this comment.
good catch, I'll update. Probably will hide those controls since some of the values are channel specific
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP