Skip to content

Partial Storybook CSF 3 story conversions#3824

Merged
LFDanLu merged 19 commits into
mainfrom
csf_3_conversions
Jan 13, 2023
Merged

Partial Storybook CSF 3 story conversions#3824
LFDanLu merged 19 commits into
mainfrom
csf_3_conversions

Conversation

@LFDanLu
Copy link
Copy Markdown
Member

@LFDanLu LFDanLu commented Dec 8, 2022

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

Comment thread packages/@react-spectrum/actionbar/stories/ActionBar.stories.tsx Outdated
@LFDanLu LFDanLu changed the title (WIP) CSF 3 conversions Storybook CSF 3 story conversions Dec 10, 2022
reidbarber
reidbarber previously approved these changes Dec 12, 2022
Copy link
Copy Markdown
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things I noticed we can improve, but they can definitely be handled in a follow-up:

For argTypes that we don't want to appear in the Controls panel (i.e. children, onOpenChange), we can add control: false.

onChange: action('onChange'),
onChangeEnd: action('onChangeEnd')
},
argTypes: {
Copy link
Copy Markdown
Member

@reidbarber reidbarber Dec 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently updating the channel control (a text field) gives an error, so we might need this:

      channel: {
        control: {
          type: 'select',
          options: ['red', 'green', 'blue', 'hue', 'saturation', 'lightness', 'alpha']
        }
      }

You could also add this to any of the other color stories for xChannel, yChannel, etc.

Copy link
Copy Markdown
Member Author

@LFDanLu LFDanLu Dec 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I'll update. Probably will hide those controls since some of the values are channel specific

@LFDanLu LFDanLu changed the title Storybook CSF 3 story conversions Partial Storybook CSF 3 story conversions Jan 4, 2023
@rspbot
Copy link
Copy Markdown

rspbot commented Jan 13, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Jan 13, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@LFDanLu LFDanLu merged commit 853beb2 into main Jan 13, 2023
@LFDanLu LFDanLu deleted the csf_3_conversions branch January 13, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants