Skip to content

Fix strict mode storybook #3837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LFDanLu wants to merge 1 commit into from
Closed

Fix strict mode storybook #3837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .storybook/preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ export const parameters = {
};

export const decorators = [
Story => (
story => (
Copy link
Copy Markdown
Member

@snowystinger snowystinger Dec 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you know, we can probably get rid of this decorator, there are story options that do this now using layout: center
https://storybook.js.org/docs/react/configure/story-layout

Copy link
Copy Markdown
Member Author

@LFDanLu LFDanLu Dec 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will investigate this option later for the decorator I'll be adding to support scrolling in all stories

<VerticalCenter style={{alignItems: 'center', minHeight: '100vh', boxSizing: 'border-box', display: 'flex', justifyContent: 'center'}}>
<Story />
{story()}
Copy link
Copy Markdown
Member

@snowystinger snowystinger Dec 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't we make this change originally because it was crashing storybook as you have it now?

</VerticalCenter>
),
withProviderSwitcher
Expand Down