Remove need for onMove events#3858
Merged
Merged
Conversation
LFDanLu
approved these changes
Dec 16, 2022
Member
LFDanLu
left a comment
There was a problem hiding this comment.
Seems to work well, confirmed that the resizer icon only appears when dragging with my mouse and not when using the keyboard. Also verified that the scrolling behavior when dragging past the edge of the table only happens when using keyboard and doesn't happen when resize is started via keyboard but then continued via mouse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
To test this, the cursor should change in real-time as before. Indicating when you can resize in both directions or when you can resize only to the left or only to the right.
The cursor should only change for mouse, and should return to normal styles when keyboard is used to resize.
The blue line indicator of resizing should update as the resizing occurs and should also be on the currently resizing column.
🧢 Your Project: