Skip to content

combobox: changing example to be more inclusive#3866

Merged
snowystinger merged 1 commit into
adobe:mainfrom
cgood92:patch-1
Dec 20, 2022
Merged

combobox: changing example to be more inclusive#3866
snowystinger merged 1 commit into
adobe:mainfrom
cgood92:patch-1

Conversation

@cgood92
Copy link
Copy Markdown
Contributor

@cgood92 cgood92 commented Dec 20, 2022

There is not an associated Git Issue.

This is merely updating documentation to remove a phrase that may be offensive to some. By changing the documentation example very slightly, this is more inclusive.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

There are no test instructions, this is merely updating documentation

@snowystinger
Copy link
Copy Markdown
Member

Hey, thanks for the pull! We just need you to follow https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement so we can merge it. After signing, you may need to close and reopen this PR

@cgood92 cgood92 closed this Dec 20, 2022
@cgood92 cgood92 reopened this Dec 20, 2022
@cgood92
Copy link
Copy Markdown
Contributor Author

cgood92 commented Dec 20, 2022

Hey, thanks for the pull! We just need you to follow https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement so we can merge it. After signing, you may need to close and reopen this PR

Thank you so much. I have signed the agreement, closed, and now re-opened this PR.

@snowystinger snowystinger merged commit ee3cc80 into adobe:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants