Enable strict mode toggle in storybook#3870
Merged
Merged
Conversation
the globals are updating anymore for some reason...
Member
Author
|
Reopening due to provider breaking in stories upon save (components using useProvider will complain that |
This was referenced Jan 3, 2023
core issue is with react fast refresh in parcel, fix to be patched there eventually. For now this is a stopgap fix, see vitejs/vite#3301 for a similar issue
Member
Author
|
Note that saving changes in certain files (FocusScope) may cause the storybook to lag a bit, most likely due to some fast refresh shenanigans. At least it doesn't crash anymore though, final fix will be done in Parcel |
snowystinger
approved these changes
Jan 5, 2023
reidbarber
approved these changes
Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
Test locally, toggle strict mode in storybook via the toolbar at the top. Check that stories with overlays break when strict mode is enabled
🧢 Your Project:
RSP