Skip to content

Revert "Remove PR commenting for now so builds pass (#3826)"#3888

Merged
devongovett merged 6 commits into
mainfrom
bring_back_commenting
Jan 12, 2023
Merged

Revert "Remove PR commenting for now so builds pass (#3826)"#3888
devongovett merged 6 commits into
mainfrom
bring_back_commenting

Conversation

@LFDanLu
Copy link
Copy Markdown
Member

@LFDanLu LFDanLu commented Jan 5, 2023

This reverts commit 5c1920e.

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@LFDanLu
Copy link
Copy Markdown
Member Author

LFDanLu commented Jan 5, 2023

Testing to see if adobe-bot is back

EDIT: :(

@LFDanLu LFDanLu closed this Jan 5, 2023
@devongovett devongovett deleted the bring_back_commenting branch January 5, 2023 02:27
@LFDanLu LFDanLu restored the bring_back_commenting branch January 11, 2023 01:30
@LFDanLu LFDanLu reopened this Jan 11, 2023
@devongovett
Copy link
Copy Markdown
Member

FYI there's no GitHub token in CircleCI so this won't work. We would need to get a new one.

@LFDanLu
Copy link
Copy Markdown
Member Author

LFDanLu commented Jan 11, 2023

@devongovett Ah gotcha, thanks for the heads up

@rspbot
Copy link
Copy Markdown

rspbot commented Jan 12, 2023

Build successful! 🎉

snowystinger
snowystinger previously approved these changes Jan 12, 2023
This reverts commit f2755bf.
@rspbot
Copy link
Copy Markdown

rspbot commented Jan 12, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Jan 12, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Jan 12, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }

@devongovett devongovett merged commit e42010c into main Jan 12, 2023
@devongovett devongovett deleted the bring_back_commenting branch January 12, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants