Skip to content

Match column resize aria hook interface to other interfaces#3889

Merged
snowystinger merged 7 commits into
mainfrom
match-aria-hook-interface-pattern
Jan 11, 2023
Merged

Match column resize aria hook interface to other interfaces#3889
snowystinger merged 7 commits into
mainfrom
match-aria-hook-interface-pattern

Conversation

@snowystinger
Copy link
Copy Markdown
Member

@snowystinger snowystinger commented Jan 6, 2023

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

devongovett
devongovett reviewed Jan 9, 2023
View reviewed changes
Comment thread packages/@react-aria/table/src/useTableColumnResize.ts Outdated
Comment thread packages/@react-aria/table/src/useTableColumnResize.ts Outdated
devongovett
devongovett reviewed Jan 10, 2023
View reviewed changes
Comment thread packages/@react-spectrum/table/src/TableView.tsx Outdated
snowystinger
snowystinger commented Jan 10, 2023
View reviewed changes
Comment thread packages/@react-stately/table/src/useTableColumnResizeState.ts
devongovett
devongovett reviewed Jan 10, 2023
View reviewed changes
Comment thread packages/@react-stately/table/src/useTableColumnResizeState.ts
LFDanLu
LFDanLu approved these changes Jan 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snowystinger snowystinger merged commit dc035b2 into main Jan 11, 2023
@snowystinger snowystinger deleted the match-aria-hook-interface-pattern branch January 11, 2023 01:26
@snowystinger snowystinger self-assigned this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devongovett devongovett devongovett approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees

@snowystinger snowystinger

Labels

None yet

Projects

RSP Component Milestones
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snowystinger @devongovett @LFDanLu