fix:(#4144): SearchField: contextual help button displayed wrong#4164
Merged
Conversation
Member
|
GET_BUILD |
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
Member
|
Ran chromatic VRT, everything is green https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=463 I'm a little worried about why we had that line, one of us will need to do a more in-depth look, but it's passing the automation testing. |
snowystinger
approved these changes
Apr 4, 2023
devongovett
approved these changes
Apr 4, 2023
Member
|
Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4144
Can't be tested in storybook. It is working correctly in storybook, but wrong in docs and production builds. The css import order must be different between storybook and production builds, which should probably be investigated separately by a spectrum team member so that storybook always accurately reflects production.
✅ Pull Request Checklist:
📝 Test Instructions:
Confirm contextual help icon appears beside label in docs build, and storybook behaviour remains unchanged when a contextual help label is applied for both
topandsidelabel positions.🧢 Your Project:
none. just exploring library