Skip to content

fix:(#4144): SearchField: contextual help button displayed wrong#4164

Merged
devongovett merged 2 commits into
adobe:mainfrom
dsmmcken:seachfield-contextual-help
Apr 4, 2023
Merged

fix:(#4144): SearchField: contextual help button displayed wrong#4164
devongovett merged 2 commits into
adobe:mainfrom
dsmmcken:seachfield-contextual-help

Conversation

@dsmmcken
Copy link
Copy Markdown
Contributor

@dsmmcken dsmmcken commented Mar 6, 2023

Closes #4144

Can't be tested in storybook. It is working correctly in storybook, but wrong in docs and production builds. The css import order must be different between storybook and production builds, which should probably be investigated separately by a spectrum team member so that storybook always accurately reflects production.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Confirm contextual help icon appears beside label in docs build, and storybook behaviour remains unchanged when a contextual help label is applied for both top and side label positions.

🧢 Your Project:

none. just exploring library

@snowystinger
Copy link
Copy Markdown
Member

GET_BUILD

@rspbot
Copy link
Copy Markdown

rspbot commented Mar 6, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Mar 6, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@snowystinger
Copy link
Copy Markdown
Member

Ran chromatic VRT, everything is green https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=463

I'm a little worried about why we had that line, one of us will need to do a more in-depth look, but it's passing the automation testing.

@devongovett devongovett merged commit 8a6fef1 into adobe:main Apr 4, 2023
@devongovett
Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SearchField ContextualHelp not appearing inline.

4 participants