Fix useResizeObserver timing#4202
Closed
snowystinger wants to merge 1 commit into
Closed
Conversation
reidbarber
approved these changes
Mar 14, 2023
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
devongovett
reviewed
Mar 15, 2023
| onResize(); | ||
| }); | ||
| // call onResize immediately | ||
| onResize(); |
Member
There was a problem hiding this comment.
wait so doesn't this re-introduce the issue fixed by #2891? Why would the requestAnimationFrame be needed at all now if it does nothing?
Member
Author
There was a problem hiding this comment.
sigh, you're right, it did re-introduce it. I'll revert the original PR and close this one until we can figure out something else.
Member
Author
|
Closing because this reintroduced the original bug. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: