Skip to content

Fix useResizeObserver timing#4202

Closed
snowystinger wants to merge 1 commit into
mainfrom
fix-resize-observer-timing
Closed

Fix useResizeObserver timing#4202
snowystinger wants to merge 1 commit into
mainfrom
fix-resize-observer-timing

Conversation

@snowystinger
Copy link
Copy Markdown
Member

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link
Copy Markdown

rspbot commented Mar 15, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Mar 15, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

onResize();
});
// call onResize immediately
onResize();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait so doesn't this re-introduce the issue fixed by #2891? Why would the requestAnimationFrame be needed at all now if it does nothing?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh, you're right, it did re-introduce it. I'll revert the original PR and close this one until we can figure out something else.

@snowystinger
Copy link
Copy Markdown
Member Author

Closing because this reintroduced the original bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants