Skip to content

Revert Fix useResizeObserver loop limit exceeded warning (#2891)#4204

Merged
snowystinger merged 2 commits into
mainfrom
Revert-resize-observer-loop-error-fix
Mar 15, 2023
Merged

Revert Fix useResizeObserver loop limit exceeded warning (#2891)#4204
snowystinger merged 2 commits into
mainfrom
Revert-resize-observer-loop-error-fix

Conversation

@snowystinger
Copy link
Copy Markdown
Member

Closes
Reverts #2891 because it introduced a bug where overlays would not position correctly. Looking into possible fixes. In the meantime, reverting.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link
Copy Markdown

rspbot commented Mar 15, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Mar 15, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Mar 15, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@snowystinger snowystinger merged commit dabf87d into main Mar 15, 2023
@snowystinger snowystinger deleted the Revert-resize-observer-loop-error-fix branch March 15, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants