Skip to content

SearchAutocomplete: add help text support#4327

Merged
reidbarber merged 4 commits into
mainfrom
searchautocomplete-helptext
Apr 6, 2023
Merged

SearchAutocomplete: add help text support#4327
reidbarber merged 4 commits into
mainfrom
searchautocomplete-helptext

Conversation

@reidbarber
Copy link
Copy Markdown
Member

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 3, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 4, 2023

Copy link
Copy Markdown
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would be nice to get some chromatic stories for this. If you wanna do that as a followup that is fine too

@snowystinger
Copy link
Copy Markdown
Member

snowystinger commented Apr 4, 2023

Chromatic currently failing due to tags missing translations. The searchautocomplete stories we have all passed. We can safely ignore the chromatic failure for this PR.

Can either make an empty commit or when main is merged next the chromatic review won't apply anymore.

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 4, 2023

Copy link
Copy Markdown
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we wanna hold for after the release? If not, I'd prefer adding the chromatic stories for safety

@reidbarber
Copy link
Copy Markdown
Member Author

@LFDanLu I'm fine with either, but lean towards waiting since we've tested everything. Also I noticed we don't have help text is most other field components chromatic stories either, so we may want to add those soon as well.

@reidbarber
Copy link
Copy Markdown
Member Author

@LFDanLu I'll merge this now, and add chromatic stories in a separate PR. There may be a few more style fixes we want to get into SearchAutocomplete before getting a baseline.

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 6, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 6, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@react-aria/autocomplete

SearchAutocompleteAria

 SearchAutocompleteAria<T> {
   clearButtonProps: AriaButtonProps
+  descriptionProps: DOMAttributes
+  errorMessageProps: DOMAttributes
   inputProps: InputHTMLAttributes<HTMLInputElement>
   labelProps: DOMAttributes
   listBoxProps: AriaListBoxOptions<T>
 }

it changed:

  • useSearchAutocomplete

@reidbarber reidbarber merged commit 0a1d0cd into main Apr 6, 2023
@reidbarber reidbarber deleted the searchautocomplete-helptext branch April 6, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants