SearchAutocomplete: add help text support#4327
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
LFDanLu
left a comment
There was a problem hiding this comment.
LGTM, but would be nice to get some chromatic stories for this. If you wanna do that as a followup that is fine too
|
Chromatic currently failing due to tags missing translations. The searchautocomplete stories we have all passed. We can safely ignore the chromatic failure for this PR. Can either make an empty commit or when main is merged next the chromatic review won't apply anymore. |
|
Build successful! 🎉 |
LFDanLu
left a comment
There was a problem hiding this comment.
LGTM, do we wanna hold for after the release? If not, I'd prefer adding the chromatic stories for safety
|
@LFDanLu I'm fine with either, but lean towards waiting since we've tested everything. Also I noticed we don't have help text is most other field components chromatic stories either, so we may want to add those soon as well. |
|
@LFDanLu I'll merge this now, and add chromatic stories in a separate PR. There may be a few more style fixes we want to get into SearchAutocomplete before getting a baseline. |
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } @react-aria/autocompleteSearchAutocompleteAria SearchAutocompleteAria<T> {
clearButtonProps: AriaButtonProps
+ descriptionProps: DOMAttributes
+ errorMessageProps: DOMAttributes
inputProps: InputHTMLAttributes<HTMLInputElement>
labelProps: DOMAttributes
listBoxProps: AriaListBoxOptions<T>
}it changed:
|
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: