Stop dialog inside collection from closing due to typeahead#4328
Conversation
|
Build successful! 🎉 |
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
Verified the fix locally by modifying the 'with dialog trigger' TableView story, mind adding a story or modifying that one so we can test via storybook?
| expect(document.activeElement).toBe(getCell(tree, 'Sam')); | ||
| }); | ||
|
|
||
| describe('', function () { |
There was a problem hiding this comment.
Mind updating this describe and the test case title so it is specific to this fix?
There was a problem hiding this comment.
I didn't want to add a new story because it's covered pretty well by the test and it's a big enough example to be annoying
let me see if I can do the add it as a story and use it in the test
There was a problem hiding this comment.
done, found a new issue though. pre-existing. keyboard navigate to the first rows action button, press 'j' key. focus will move to the last row where the 'J' is, but it will not scroll to it. should address in followup.
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
4 participants
Closes #3957
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: