Skip to content

SearchAutocomplete: fix duplicate events#4337

Merged
reidbarber merged 5 commits into
mainfrom
searchautocomplete-fix-dup-event
Apr 11, 2023
Merged

SearchAutocomplete: fix duplicate events#4337
reidbarber merged 5 commits into
mainfrom
searchautocomplete-fix-dup-event

Conversation

@reidbarber
Copy link
Copy Markdown
Member

Closes #3684

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Comment thread packages/@react-aria/autocomplete/src/useSearchAutocomplete.ts
@rspbot
Copy link
Copy Markdown

rspbot commented Apr 5, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 5, 2023

@reidbarber reidbarber added the small review Easy to review PR label Apr 10, 2023
@rspbot
Copy link
Copy Markdown

rspbot commented Apr 11, 2023

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 11, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@reidbarber reidbarber merged commit 42c65e6 into main Apr 11, 2023
@reidbarber reidbarber deleted the searchautocomplete-fix-dup-event branch April 11, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small review Easy to review PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

onKeyDown event on the SearchAutocomplete component is getting fired twice.

4 participants