TagGroup: remove useTagGroupState#4359
Merged
Merged
Conversation
reidbarber
commented
Apr 11, 2023
| let ref = React.useRef(null); | ||
|
|
||
| let state = useTagGroupState(props); | ||
| let state = useListState(props); |
Member
Author
There was a problem hiding this comment.
This should be fine to go out now, and is necessary to build.
|
Build successful! 🎉 |
snowystinger
approved these changes
Apr 11, 2023
devongovett
approved these changes
Apr 11, 2023
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } @react-aria/taguseTag useTag<T> {
props: AriaTagProps<T>
- state: TagGroupState<T>
+ state: ListState<T>
ref: RefObject<FocusableElement>
returnVal: undefined
}useTagGroup useTagGroup<T> {
props: AriaTagGroupProps<T>
- state: TagGroupState<T>
+ state: ListState<T>
ref: RefObject<HTMLElement>
returnVal: undefined
}tmp/dist/base-api/@react-stately/taguseTagGroupStatechanged by:
-useTagGroupState<T extends {}> {
- props: TagGroupProps<T>
- returnVal: undefined
-}
+TagGroupState-TagGroupState<T> {
- onRemove?: (Key) => void
-}
+it changed:
TagGroupProps-TagGroupProps<T> {
- allowsRemoving?: boolean
- maxRows?: number
- onRemove?: (Key) => void
-}
+ |
cgood92
pushed a commit
to cgood92/react-spectrum
that referenced
this pull request
May 9, 2023
* remove useTagGroup * fix type * remove deps * lint * remove from docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can remove
useTagGroupStatesinceuseListStateshould have everything we need to manage state for a tag group.✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: