Fix diacritics in textfields#4579
Conversation
|
Build successful! 🎉 |
yihuiliao
left a comment
There was a problem hiding this comment.
checked in firefox, safari, and chrome on mac and it looks good! doesn't seem to get cut off
reidbarber
left a comment
There was a problem hiding this comment.
LGTM, we should run chromatic
yeah, i'm running it on main right now, then I'll run it here |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
Closes #3983
✅ Pull Request Checklist:
📝 Test Instructions:
Go to new story, change the locale, a different string will appear for each one. The big difference is if you toggle Zalgo text, here you can see the full range of area in which we can display a diacritic has been increased. It's gibberish, just shows where the cut off is. If you pull this locally, you can ever the change and compare to where it used to be cut off.
Note, this is safe, we'll never extend out beyond the bounds of the textfield itself, the text is overflow hidden if it tries to. With the exception of Zalgo and maybe some Tibet strings which Spectrum doesn't support anyways, the diacritics should never extend this far in the vertical range.
🧢 Your Project: