You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Closes#6298
Alternative to #6357
I believe the issue is that in our layouts, we were calling isVisible which checked if the layoutInfo intersects with the visible rect. This always came back as true when the height was 0 because with the display hidden, everything was 0,0. I could fix it in isVisible, but then we have to remember it for all other layouts. Instead, in Virtualizer, we just don't fetch any layout infos or do any detection if the height is 0. I don't think we'll want to render anything if the height is 0 anyways, so this should be fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6298
Alternative to #6357
I believe the issue is that in our layouts, we were calling
isVisiblewhich checked if the layoutInfo intersects with the visible rect. This always came back as true when the height was 0 because with the display hidden, everything was 0,0. I could fix it inisVisible, but then we have to remember it for all other layouts. Instead, in Virtualizer, we just don't fetch any layout infos or do any detection if the height is 0. I don't think we'll want to render anything if the height is 0 anyways, so this should be fine.✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: