Cap overlay max height to 100vh on initial render#6525
Conversation
|
## API Changes
unknown top level export { type: 'any' } |
4 participants
{{ message }}
Merged
reidbarber
approved these changes
Jun 11, 2024
snowystinger
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the performance issue introduced by #6451 when opening a ComboBox or Picker (or any virtualized collection inside a popover). Since virtualizer layout occurs during render, it can now occur prior to the popover being fully positioned. Without a max-height, this resulted in all collection items being rendered to the DOM. We already cap the max-height to the size of the viewport just before positioning, but didn't have any max-height before that (in the initial render). Adding
100vhhere fixes the problem. 🤞 that it doesn't break anything else.