Skip to content

chore: adding width picker to tab collapse story for mobile testing#7460

Closed
ktabors wants to merge 2 commits into
mainfrom
tab-collapse-mobile-story
Closed

chore: adding width picker to tab collapse story for mobile testing#7460
ktabors wants to merge 2 commits into
mainfrom
tab-collapse-mobile-story

Conversation

@ktabors
Copy link
Copy Markdown
Collaborator

@ktabors ktabors commented Dec 4, 2024

From testing. We couldn't test tab collapse on mobile.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

test "Tabs" -> "Dynamic" on a mobile device

🧢 Your Project:

RSP

Comment thread packages/@react-spectrum/s2/stories/Tabs.stories.tsx Outdated
@rspbot
Copy link
Copy Markdown

rspbot commented Dec 4, 2024

Copy link
Copy Markdown
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to take a different approach that doesn't involve a picker in fix: Tabs from testing
I think we can close this one.

of note, it's still horrible on iOS18 because of the iOS18 bug, i'd forgotten how bad it was

@ktabors ktabors closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants