fix: Tabs infinite loop#7487
Merged
Merged
Conversation
snowystinger
changed the title
yihuiliao
approved these changes
Dec 6, 2024
devongovett
approved these changes
Dec 6, 2024
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
* Revert "chore: Update JSDocs and apis for release (#7595)" This reverts commit 101d077. * Revert "fix: Tabs infinite loop (#7487)" This reverts commit 8228e4e. * Revert "fix: Tabs from testing (#7463)" This reverts commit 494e01c. * Revert "feat: Tabs collapse behaviour (#7202)" This reverts commit cd4da2b. * add stuff back that we still want * update lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
An infinite loop and wrong items in the tablist could occur if a collection was provided as a child of the TabPanel because we provide a Custom Collection Renderer context, which was leaking down into the TabPanels children. This stops that from happening unintentionally
This could be observed in the S2 Popover story for 'control center' where a menu was used inside a tabpanel
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: