fix: @react-stately/virtualizer dependencies#8724
Merged
Merged
Conversation
Contributor
Author
|
Somebody please update the lockfile when reviewing 🙏 |
LFDanLu
approved these changes
Aug 29, 2025
snowystinger
approved these changes
Sep 1, 2025
Member
snowystinger
left a comment
There was a problem hiding this comment.
yeah, this was old and shouldn't result in any issue even though it technically goes against the direction our dependencies should adhere to, now it'll duplicate that code. I think it's ok though, it's very small
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was mistakenly added all the way back in #994
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: