Skip to content

Move isRequired from LabelableProps to SpectrumLabelableProps #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devongovett merged 1 commit into from
Aug 4, 2020
Merged

Move isRequired from LabelableProps to SpectrumLabelableProps #877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/@react-types/shared/src/labelable.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@ export type NecessityIndicator = 'icon' | 'label';

export interface LabelableProps {
/** The content to display as the label. */
label?: ReactNode,
/** Whether the label is labeling a required field or group. */
isRequired?: boolean
label?: ReactNode
}

export interface SpectrumLabelableProps extends LabelableProps {
Expand All @@ -38,5 +36,9 @@ export interface SpectrumLabelableProps extends LabelableProps {
* Whether the required state should be shown as an icon or text.
* @default 'icon'
*/
necessityIndicator?: NecessityIndicator
necessityIndicator?: NecessityIndicator,
/**
* Whether the label is labeling a required field or group.
*/
isRequired?: boolean
}