SSR - Add more component tests#899
Merged
Merged
Conversation
snowystinger
reviewed
Aug 6, 2020
Member
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
any chance we can add it to our workflows for circle?
Member
Author
|
Do you want to ever have our CI pass ever again?
|
Member
Author
|
The plan is to add it to CI when they all pass 😸 |
LFDanLu
approved these changes
Aug 6, 2020
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
Looks good to me, what do you think about adding a SSR test template to the plop templates?
|
Build successful! 🎉 |
devongovett
approved these changes
Aug 11, 2020
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #760, #699
Follow up from #835
This is to cover the basic rendering of the rest of our components in a server rendered environment. Missing Icon for now.