Ensure bash shebang lines are portable#53
Merged
kzadorozhny merged 1 commit intoadobe:masterfrom Jan 29, 2021
Merged
Conversation
AleksanderGondek
force-pushed
the
issue-52-rules-should-use-usr-bin-env-bash
branch
from
8079e42 to
a2e3483
Compare
kzadorozhny
requested changes
Jan 29, 2021
This commit ensures all instances of bash shebang line are utilizing portable '/usr/bin/env bash', allowing for greater portability of the rules_gitops
AleksanderGondek
force-pushed
the
issue-52-rules-should-use-usr-bin-env-bash
branch
from
a2e3483 to
43470c3
Compare
kzadorozhny
approved these changes
Jan 29, 2021
Member
kzadorozhny
left a comment
kzadorozhny
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
Contributor
Author
|
Thank you for open-sourcing this awesome rules :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit ensures all instances of bash shebang line are utilizing portable
/usr/bin/env bash, allowing for greater portability of the rules_gitopsRelated Issue
Fixed #52
Motivation and Context
I would like to commit upstream changes which made it possible to run adobe rules_gitops on Linux OS'es which do not have
/bin/bashexecutable.How Has This Been Tested?
I have been using patched (in same manner like in this commit) rules_gitops in my projects.
Types of changes
Checklist: