Merged
Conversation
10 tasks
kzadorozhny
reviewed
Oct 17, 2022
skylib/k8s.bzl
Outdated
| attrs = { | ||
| "cluster": attr.string(), | ||
| "server": attr.string(), | ||
| "symlink": attr.bool(), |
Member
There was a problem hiding this comment.
maybe call it use_host_config
kzadorozhny
approved these changes
Oct 17, 2022
arturo-skydio
pushed a commit
to Skydio/rules_gitops
that referenced
this pull request
Oct 5, 2023
* fixes additional calls to kubectl that were always using default user * skylib/k8s.bzl changes from michaelschiff/rules_gitops * rename symlink to use_host_config per code review Co-authored-by: Michael Schiff <schiff.michael@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use symlink to configure k8s cluster instead of generating a config file in repo rule
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: