Skip to content

feat: introduce default config for organic-keywords report (SITES-19317)#118

Merged
dzehnder merged 1 commit intomainfrom
organic-keywords
Jan 30, 2024
Merged

feat: introduce default config for organic-keywords report (SITES-19317)#118
dzehnder merged 1 commit intomainfrom
organic-keywords

Conversation

@dzehnder
Copy link
Copy Markdown
Contributor

No description provided.

@dzehnder
Copy link
Copy Markdown
Contributor Author

Flaky unit test, seems like the clock is one millisecond behind sometimes

 1) Base Model Tests
       Getter Method Tests
         correctly returns the updatedAt date if provided:

      AssertionError: expected '2024-01-29T18:44:13.340Z' to equal '2024-01-29T18:44:13.339Z'
      + expected - actual

@dzehnder dzehnder requested a review from ekremney January 30, 2024 08:53
@dzehnder dzehnder merged commit 4301556 into main Jan 30, 2024
@dzehnder dzehnder deleted the organic-keywords branch January 30, 2024 08:59
@iuliag
Copy link
Copy Markdown
Contributor

iuliag commented Jan 30, 2024

Flaky unit test, seems like the clock is one millisecond behind sometimes

It may well be a test that needs to be fixed, like in #88

adobe-bot pushed a commit that referenced this pull request Jan 30, 2024
# [@adobe/spacecat-shared-data-access-v1.13.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.12.0...@adobe/spacecat-shared-data-access-v1.13.0) (2024-01-30)

### Features

* introduce default config for organic-keywords report (SITES-19317) ([#118](#118)) ([4301556](4301556))
@adobe-bot
Copy link
Copy Markdown

🎉 This PR is included in version @adobe/spacecat-shared-data-access-v1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants