feat: added new status in PLG onboarding flow#1568
Merged
anshulk-public merged 8 commits intomainfrom May 5, 2026
Merged
Conversation
|
This PR will trigger a minor release when merged. |
Kanishkavijay39
approved these changes
May 5, 2026
solaris007
pushed a commit
that referenced
this pull request
May 5, 2026
## [@adobe/spacecat-shared-data-access-v3.57.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v3.56.1...@adobe/spacecat-shared-data-access-v3.57.0) (2026-05-05) ### Features * added new status in PLG onboarding flow ([#1568](#1568)) ([e1d2be5](e1d2be5))
Member
|
🎉 This PR is included in version @adobe/spacecat-shared-data-access-v3.57.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends the PLG onboarding data model with two new terminal statuses, three new review decisions, and a
createdByfield:plg-onboarding.model.jsREJECTEDandOUTDATEDtoPlgOnboarding.STATUSESCLOSED,REOPENED, andOFFBOARDEDtoPlgOnboarding.REVIEW_DECISIONSplg-onboarding.schema.jscreatedByattribute (string, optional, defaults to'system') — tracks who initiated the onboarding record; set once on creation, never updatedMotivation and Context
The previous model only had two terminal-adjacent states and two review decisions (
BYPASSED,UPHELD), which were insufficient to represent the full onboarding lifecycle:REJECTED— needed as a hard terminal state when an admin explicitly denies a waitlisted onboarding viaUPHELD. Previously the record stayed inWAITLISTEDindefinitely with no way to distinguish "pending review" from "denied."OUTDATED— needed as a soft terminal state for records that are no longer the active onboarding attempt (superseded by a new domain, manually closed, or deprovisioned). Distinct fromINACTIVEto avoid corrupting the ASO UI dropdown logic.CLOSED/OFFBOARDED/REOPENED— system-generated review decisions written when an admin transitions a record toOUTDATEDvia the newPATCH /plg/onboard/:onboardingId/statusAPI. Each decision captures the source state:WAITLISTED → CLOSED,ONBOARDED → OFFBOARDED,REJECTED → REOPENED.createdBy— fills the audit gap whereupdatedBywas tracked but the original creator was not, making it impossible to distinguish customer-initiated records from admin- or system-created ones.How Has This Been Tested?
plg-onboardingtest suite pass (plg-onboarding.model.test.js,plg-onboarding.schema.test.js,plg-onboarding.collection.test.js)createdBydefault behaviour verified via schema attribute testPlease ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!