fix(data-access): replace hard-coded IT hook timeout with shared constant#1579
Merged
fix(data-access): replace hard-coded IT hook timeout with shared constant#1579
Conversation
…tant Introduces IT_HOOK_TIMEOUT (30 s) in test/it/util/util.js and references it from all 37 IT test files instead of repeating the magic number. The v5.x mysticat-data-service image runs more migrations on startup, causing seedDatabase() to exceed the previous 10 s ceiling on cold CI runs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
solaris007
pushed a commit
that referenced
this pull request
May 4, 2026
## [@adobe/spacecat-shared-data-access-v3.56.1](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v3.56.0...@adobe/spacecat-shared-data-access-v3.56.1) (2026-05-04) ### Bug Fixes * **data-access:** replace hard-coded IT hook timeout with shared constant ([#1579](#1579)) ([4fbc6e0](4fbc6e0)), closes [#1573](#1573)
Member
|
🎉 This PR is included in version @adobe/spacecat-shared-data-access-v3.56.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session Summary
PR #1573 —
feat(data-access): add readAll capability to Consumer.CAPABILITIESReview comments addressed (pushed to branch, now merged):
Consumer.CAPABILITIESexplainingreadAllis a scope+verb hybrid, only meaningful on opted-in routes"accepts the readAll action for any registered entity"→"accepts site:readAll and organization:readAll capabilities"expect(mockElectroService.entities.consumer.create).to.have.been.calledOnceCI failures investigated
mysticat-data-service:v1.67.8 not foundTrialUser/TrialUserActivity IT timeoutHTML Utils warmup delay: expected 749 to be ≥ 750tokowaka-clientNew PR branch —
fix/it-timeout-constant(from main)v5.1.1indocker-compose.ymlIT_HOOK_TIMEOUT = 30000constant intest/it/util/util.js10000