Skip to content

fix: update config packaging #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekremney merged 1 commit into from
Feb 28, 2024
Merged

fix: update config packaging #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/spacecat-shared-data-access/src/models/organization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const Organization = (data = {}) => {
throw new Error('Config must be provided');
}

self.state.config = Config.toDynamoItem(config);
self.state.config = Config(config);
self.touch();

return self;
Expand Down
7 changes: 3 additions & 4 deletions packages/spacecat-shared-data-access/test/unit/models/organization.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import { expect } from 'chai';
import { createOrganization } from '../../../src/models/organization.js';
import { sleep } from '../util.js';
import { Config } from '../../../src/models/site/config.js';

const validData = {
id: '1111111',
Expand Down Expand Up @@ -87,7 +86,7 @@ describe('Organization Model Tests', () => {
});

it('updates config correctly', () => {
const conf = Config({
const conf = {
slack: {
workspace: 'workspace',
channel: 'channel',
Expand All @@ -98,7 +97,7 @@ describe('Organization Model Tests', () => {
mentions: [{ slack: ['slackId'] }],
}],
audits: {},
});
};
organization.updateConfig(conf);
const updatedConf = organization.getConfig();
expect(updatedConf.slack).to.be.an('object');
Expand Down Expand Up @@ -145,7 +144,7 @@ describe('Organization Model Tests', () => {

await sleep(20);

organization.updateConfig(Config({}));
organization.updateConfig({});

expect(organization.getUpdatedAt()).to.not.equal(initialUpdatedAt);
});
Expand Down