[Dialog] spectrum-Dialog--dismissable and spectrum-Dialog--fullscreen* are not compatible

[Westbrook]

Description

Usage of .spectrum-Dialog--dismissable and its button.spectrum-Dialog-closeButton element are not compatible with .spectrum-Dialog--fullscreen* and it should be documented as such.

Currently, there are no documented usage of this combination. However, when users use these in concert the patterns are delivered in a less than palatable fashion. adobe/spectrum-web-components#1088 We should explicitly outline that these should not be used together.

Link to documentation

https://opensource.adobe.com/spectrum-css/dialog.html

Additional context

We might also want to discuss defensively coding them out of the system. This is done in the latest code for the way that .spectrum-Dialog--dismissable will not allow the presentation of .spectrum-Dialog-buttonGroup content.

[lazd]

Uhg, even the fullscreen pattern is considered a contribution, it's a relic from years past. Dialog needs an overhaul...

[castastrophe]

Updated link: https://opensource.adobe.com/spectrum-css/?path=/docs/components-dialog--docs

The ask here at this time is to update the documentation to explicitly state that dismissible is not allowed to be used in conjunction with the fullscreen versions of the Dialog.

[najikahalsema]

Fixed via #3347