feat: add core tokens#1429
Merged
Merged
Conversation
1 task
BREAKING CHANGE: .spectrum-ActionButton-icon is now required on icons BREAKING CHANGE: .spectrum--express must be added to support Express ActionButton
lazd
force-pushed
the
lazd/CSS-75-core-tokens-pre
branch
from
0ce1cb5 to
774d09e
Compare
Westbrook
reviewed
May 17, 2022
also, fix bug where some used tokens were not caught!
it's unused, but it should be there
note: this code needs some work and some tests
also add license
document nothing and add tests for nothing, name things badly
shhh, still no tests for these options...
Co-authored-by: Patrick Fulton <360251+pfulton@users.noreply.github.com>
…css into lazd/CSS-143-splitinator
pfulton
force-pushed
the
lazd/CSS-75-core-tokens-pre
branch
3 times, most recently
from
635e51f to
716492f
Compare
BREAKING CHANGE: .spectrum-ActionButton-icon is now required on icons BREAKING CHANGE: .spectrum--express must be added to support Express ActionButton
pfulton
force-pushed
the
lazd/CSS-75-core-tokens-pre
branch
from
716492f to
640361d
Compare
✅ Deploy Preview for spectrum-css ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pfulton
force-pushed
the
lazd/CSS-75-core-tokens-pre
branch
from
7b844bf to
b7a993b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds core tokens and a new package,
components/coretokensthat builds the CSS custom properties.This is a BREAKING CHANGE since the lightest theme is removed.Just kidding, we added it back.It's IS a BREAKING CHANGE only for components that have been migrated to core tokens because
.spectrum--expressis now required for the Express theme.To-do list
custom.csscustom.css- [ ] Explore slimmer build systemNext steps
lazd/CSS-75-core-tokens-pre@spectrum-css/tokensand@spectrum-css/actionbuttonfrom thelazd/CSS-75-core-tokens-prebranchlazd/CSS-75-core-tokens-preintomainand graduate ActionButton out of beta (breaking change: requiresspectrum-ActionButton--iconand needsspectrum--expressfor Express mode)