Skip to content

fix(textfield): diacritics & descenders cut off in some languages#1910

Closed
pfulton wants to merge 2 commits into
mainfrom
pfulton/fix--textfield-diacritics
Closed

fix(textfield): diacritics & descenders cut off in some languages#1910
pfulton wants to merge 2 commits into
mainfrom
pfulton/fix--textfield-diacritics

Conversation

@pfulton
Copy link
Copy Markdown
Collaborator

@pfulton pfulton commented May 31, 2023 •
edited
Loading

🚨 DO NOT MERGE 🚨

Description

Test/fix branch for prototyping line-height changes.

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with:

Screenshots

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested these changes in Windows High Contrast mode.
  • I have updated any relevant storybook stories and templates.
  • If my change(s) include visual change(s), a designer has reviewed and approved those changes.
  • This pull request is ready to merge.

@pfulton pfulton added ask design Questions or topics for the design team wip This is a work in progress, don't judge. do not merge A flag for a branch indicating it should not be merged. labels May 31, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 31, 2023 •
edited
Loading

🚀 Deployed on https://pr-1910--spectrum-css.netlify.app

@github-actions github-actions Bot temporarily deployed to pull request May 31, 2023 18:01 Inactive
@github-actions github-actions Bot temporarily deployed to pull request May 31, 2023 19:22 Inactive
@pfulton pfulton closed this Aug 24, 2023
@pfulton
Copy link
Copy Markdown
Collaborator Author

pfulton commented Aug 24, 2023

Closed in favor of #2123

@castastrophe castastrophe deleted the pfulton/fix--textfield-diacritics branch March 6, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ask design Questions or topics for the design team do not merge A flag for a branch indicating it should not be merged. wip This is a work in progress, don't judge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pfulton