Skip to content

fix(textfield): add line-height to prevent missing diacritics #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
castastrophe merged 1 commit into from
Aug 24, 2023
Merged

fix(textfield): add line-height to prevent missing diacritics #2123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions components/textfield/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@ governing permissions and limitations under the License.
*/

.spectrum-Textfield {
--spectrum-texfield-animation-duration: var(
/* set input line-height to the height of the textfield - prevents the cutting off of diacritics in some languages */
/* disallow mod for max compatibility */
--spectrum-textfield-input-line-height: var(--spectrum-textfield-height);

--spectrum-texfield-animation-duration: var(
--spectrum-animation-duration-100
);

Expand Down Expand Up @@ -678,6 +682,8 @@ governing permissions and limitations under the License.

/********* Child Element - Input *********/
.spectrum-Textfield-input {
/* no mod defined to allow for maximum compatibility */
line-height: var(--spectrum-textfield-input-line-height);
box-sizing: border-box;
inline-size: 100%;
min-inline-size: var(
Expand Down Expand Up @@ -1251,7 +1257,8 @@ governing permissions and limitations under the License.

/*** Text Area ***/
.spectrum-Textfield--multiline {
.spectrum-Textfield-input {
--spectrum-textfield-input-line-height: normal;
.spectrum-Textfield-input {
min-inline-size: var(
--mod-text-area-min-inline-size,
var(--spectrum-text-area-min-inline-size)
Expand Down