fix(tabs): adds rules for not showing a focus indicator on tap#2275
Closed
jnjosh wants to merge 1 commit into
Closed
fix(tabs): adds rules for not showing a focus indicator on tap#2275jnjosh wants to merge 1 commit into
jnjosh wants to merge 1 commit into
Conversation
Collaborator
Author
|
Part of this issue was also to audit for other focus-indicator-on-click issues. After a very quick review these seem at least worth investigation or design discussion:
FYI @pfulton |
Contributor
|
🚀 Deployed on https://pr-2275--spectrum-css.netlify.app |
Westbrook
reviewed
Nov 12, 2023
Contributor
File metricsOverall Δ: -< 1KB ⬇ (-0.01%) tabs-< 1KB ⬇
|
a17c1d8 to
ae45e7b
Compare
Collaborator
|
@castastrophe Let me know if you get some time today to review and close this? |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Exploring options to fix a bug on tabs where
How and where has this been tested?
TBD
Regression testing
TBD
Screenshots
Note the lack of a focus indicator
To-do list