Skip to content

fix(tabs): adds rules for not showing a focus indicator on tap#2275

Closed
jnjosh wants to merge 1 commit into
mainfrom
jnjosh/CSS-637-focus-visible
Closed

fix(tabs): adds rules for not showing a focus indicator on tap#2275
jnjosh wants to merge 1 commit into
mainfrom
jnjosh/CSS-637-focus-visible

Conversation

@jnjosh
Copy link
Copy Markdown
Collaborator

@jnjosh jnjosh commented Nov 9, 2023

Description

Exploring options to fix a bug on tabs where

How and where has this been tested?

TBD

Regression testing

TBD

Screenshots

Screenshot 2023-11-08 at 10 51 16 PM

Note the lack of a focus indicator

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@jnjosh jnjosh self-assigned this Nov 9, 2023
@jnjosh
Copy link
Copy Markdown
Collaborator Author

jnjosh commented Nov 9, 2023

Part of this issue was also to audit for other focus-indicator-on-click issues. After a very quick review these seem at least worth investigation or design discussion:

  • Search Within - Shows a focus indicator around the drop down when clicking into the text field.
searchwithin
  • Floating Action Button - Shows an indicator when clicking the button.
floatingactionbutton
  • Drop Zone - Shows focus indicator when clicking into the zone.
dropzone
  • Breadcrumbs - Seem to have default with a focus indicator?
breadcrumbs

FYI @pfulton

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 9, 2023

🚀 Deployed on https://pr-2275--spectrum-css.netlify.app

@github-actions github-actions Bot temporarily deployed to pull request November 9, 2023 03:55 Inactive
Comment thread components/tabs/index.css Outdated
@Rajdeepc Rajdeepc self-assigned this Nov 14, 2023
@Rajdeepc Rajdeepc marked this pull request as ready for review November 14, 2023 15:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 14, 2023

File metrics

Overall Δ: -< 1KB ⬇ (-0.01%)

tabs

-< 1KB ⬇

File Size Diff Δ Δ%
Total changes 56.72 KB 56.54 KB -< 1KB ⬇ -0.33%
index-base.css 17.79 KB 17.73 KB -< 1KB ⬇ -0.35%
index-theme.css < 1KB < 1KB No change 🎉 0%
index-vars.css 17.97 KB 17.91 KB -< 1KB ⬇ -0.34%
index.css 17.97 KB 17.91 KB -< 1KB ⬇ -0.34%
mods.json 1.48 KB 1.48 KB No change 🎉 0%
themes/express.css < 1KB < 1KB No change 🎉 0%
themes/spectrum.css < 1KB < 1KB No change 🎉 0%

@Rajdeepc Rajdeepc requested review from Westbrook and jawinn November 15, 2023 06:48
@Rajdeepc Rajdeepc added the a11y Questions or topics for the accessibility team label Nov 15, 2023
@Rajdeepc Rajdeepc closed this Nov 30, 2023
@Rajdeepc Rajdeepc force-pushed the jnjosh/CSS-637-focus-visible branch from a17c1d8 to ae45e7b Compare November 30, 2023 11:47
@Rajdeepc Rajdeepc reopened this Nov 30, 2023
@Rajdeepc
Copy link
Copy Markdown
Collaborator

@castastrophe Let me know if you get some time today to review and close this?

@jnjosh
Copy link
Copy Markdown
Collaborator Author

jnjosh commented Nov 30, 2023

@Rajdeepc I think we have a duplicate, closing in favor of #2306

@jnjosh jnjosh closed this Nov 30, 2023
@jnjosh jnjosh deleted the jnjosh/CSS-637-focus-visible branch November 30, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Questions or topics for the accessibility team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants