fix(stepper): no longer touches InfieldButton classes#2300
Merged
Conversation
Contributor
File metricsSummaryTotal size: 4.06 MB*
Detailsinfieldbutton
stepper
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
Contributor
|
🚀 Deployed on https://pr-2300--spectrum-css.netlify.app |
95d2f20 to
3596b3c
Compare
13 tasks
c8dfb99 to
b297a7a
Compare
jawinn
reviewed
Nov 20, 2023
Collaborator
jawinn
left a comment
There was a problem hiding this comment.
Looks good to me! I just have one question about two of the newly defined custom properties on .spectrum-InfieldButton that may not be needed.
b297a7a to
4dc140f
Compare
jawinn
approved these changes
Nov 21, 2023
4b204bf to
4f76b8b
Compare
4f76b8b to
dbc7e3d
Compare
jenndiaz
pushed a commit
that referenced
this pull request
Dec 12, 2023
* fix(stepper): no longer touches InfieldButton classes * fix(stepper): button size + space match infieldbutton spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per issue #2234, Stepper shouldn't be using classes that it doesn't own. This PR adds some properties to InfieldButton and uses their mods to modify them for Stepper so that we no longer touch InfieldButton classes inside our Stepper component. There should be no visual differences to the components.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Note: When reviewing the code, filter commits so that you aren't reviewing separate changes made in PR #2234.
Tested by @jawinn
Regression testing
Validate:
To-do list