feat(dropshadows): adds dropshadows to commons#2419
Conversation
BREAKING CHANGE: Merges Express and Spectrum to create Spectrum 2
Includes new color values for Spectrum 2
31afc05 to
909f232
Compare
9a01c5a to
1b959b3
Compare
| */ | ||
|
|
||
| %spectrum-DropShadow-key { | ||
| --spectrum-drop-shadow-color-key: var(--spectrum-drop-shadow-color); |
There was a problem hiding this comment.
Would it be valuable to split out the variable definitions from the css property definitions? Just trying to think of examples where someone might want to variables and properties to source from different levels (properties at root for example).
| "concat-cli": "^4.0.0", | ||
| "npm-run-all": "^4.1.5", |
There was a problem hiding this comment.
I think these might be added from an old version. We don't use npm-run-all or concat-cli anymore for token building.
|
Just a note for future to use |
98335ab to
fec70b3
Compare
7c86724 to
0a218bc
Compare
0f20c5b to
9ff2a2c
Compare
4d9e185 to
a81c712
Compare
e03868f to
b3b3aa5
Compare
f3dd9ff to
9931a8e
Compare
6dbc850 to
ae7aedd
Compare
e0e0fd2 to
698e904
Compare
|
This was great exploratory work, thanks Jenn! |
Description
Adds S2 Drop Shadow styling to commons
Allowing for dropshadows to be imported
@import "../commons/dropshadows.css";and used with in classes@inherit: %spectrum-DropShadow-key;TO DO:
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list